[release/6.0] Use custom error message when running out of syncblocks #60592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributes to #49215
update message Co-authored-by: Jan Kotas <[email protected]>
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
mangod9
approved these changes
Oct 18, 2021
jeffschwMSFT
approved these changes
Oct 18, 2021
jeffschwMSFT
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #60013 to release/6.0
/cc @jkotas
Customer Impact
Improves diagnosability of OutOfMemory exception occurring with a plenty of free memory available in certain situation.
For historic reasons, the runtime throws OutOfMemoryException when it reaches implementation limitations for maximum number of syncblocks. This special OutOfMemoryException is hard to diagnose since it is indistinguishable from ordinary OutOfMemory exception. In #49215, it took more than 6 months to root cause this situation. It is likely that other customers are running into same issue, but they do not have patience to work for that long to diagnose it. The improved error message should make it possible to diagnose the problem within minutes.
Testing
Ad-hoc testing of the effected path.
Risk
Low. Change in error message only.