Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Disable package validation in source-build for reliability #60881

Merged
merged 3 commits into from
Nov 9, 2021

Conversation

dagood
Copy link
Member

@dagood dagood commented Oct 26, 2021

  Package validation causes flaky errors during the build. Validation isn't useful during
  source-build (it is only a guardrail for devs), so disable it during source-build to avoid the
  impact on build reliability.

This has been fixed in main, but not release/6.0. I'm submitting this PR to fix 6.0 source-build reliability in the short term while waiting for the real fixes to be ported to 6.0:

For followup removal:

@safern

@ghost
Copy link

ghost commented Oct 26, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details
  Package validation causes flaky errors during the build. Validation isn't useful during
  source-build (it is only a guardrail for devs), so disable it during source-build to avoid the
  impact on build reliability.

This has been fixed in main, but not release/6.0. I'm submitting this PR to fix 6.0 source-build reliability in the short term while waiting for the real fixes to be ported to 6.0:

@safern

Author: dagood
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

eng/packaging.targets Outdated Show resolved Hide resolved
@Anipik Anipik merged commit 76805ed into dotnet:release/6.0 Nov 9, 2021
@dagood dagood deleted the sb-skip-packagevalidation branch November 9, 2021 18:53
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants