release/6.0.1: Preserve last error in call-counting stubs #60887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kouvel
approved these changes
Oct 26, 2021
jkotas
changed the title
jeffschwMSFT
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Oct 26, 2021
leecow
added
Servicing-approved
leecow
added
Servicing-consider
|
/azp run runtime, runtime-dev-innerloop, dotnet-linker-test |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime, runtime-dev-innerloop, dotnet-linker-tests |
|
Azure Pipelines successfully started running 3 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #60886 to release/6.0
/cc @jkotas
Customer Impact
Intermittent corruption of error code returned by
Marshal.GetLastSystemError/GetLastPInvokeErrorAPIs . This bug can manifest itself as a wrong exception being thrown, or as a bogus exception being thrown when PInvoke succeed. The bug manifested itself at least 3 times in dotnet/runtime CI in last month.Testing
No reliable repro, fix verified by stepping through the code in debugger.
Risk
Low.