Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0.1] add support for macOS 12 #61028

Merged
merged 4 commits into from
Nov 10, 2021
Merged

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Oct 30, 2021

Customer Impact

macOS 12.0 Monterey was released this week, support for it missed the 6.0 release train.
without RID and fixes to determine OS version packaging may not work correctly.

Testing

I mentally verified that `dotnet --info' returns expect value. (e.g. does not fall-back to basic osx-x64)

Regression

no. new OS support.

Risk

small. Should not impact other platform. 5.x and 3.1 will need separate changes.

wfurt and others added 3 commits October 29, 2021 16:24
* fix rid processing on macOS

* Update src/native/corehost/hostmisc/pal.unix.cpp

* Update src/native/corehost/hostmisc/pal.unix.cpp

* remove extra size calculation
The `else if (major == 12)` is dead code, since the previous if `if (major > 11)` would be true for `major == 12`. Judging by the comment and code, it looks like the intention of this `else if` statement was to match `major == 11`.
@wfurt wfurt added Servicing-consider Issue for next servicing release review area-Host labels Oct 30, 2021
@wfurt wfurt added this to the 6.0.x milestone Oct 30, 2021
@ghost
Copy link

ghost commented Oct 30, 2021

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Customer Impact

macOS 12.0 Monterey was released this week, support for it missed the 6.0 release train.
without RID and fixes to determine OS version packaging may not work correctly.

Testing

I mentally verified that `dotnet --info' returns expect value. (e.g. does not fall-back to basic osx-x64)

Regression

no. new OS support.

Risk

small. Should not impact other platform. 5.x and 3.1 will need separate changes.

Author: wfurt
Assignees: -
Labels:

Servicing-consider, area-Host

Milestone: 6.0.x

@wfurt
Copy link
Member Author

wfurt commented Oct 30, 2021

BTW I'm not sure if we need usual packaging changes for platform @Anipik and how that fits with current 6.0 process. For now, I did not put them in.

@jeffschwMSFT jeffschwMSFT changed the title [release/6.0] add support for macOS 12 [release/6.0.1] add support for macOS 12 Nov 2, 2021
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We should take for consideration in 6.0.x

@leecow leecow modified the milestones: 6.0.x, 6.0.1 Nov 2, 2021
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 2, 2021
@Anipik
Copy link
Contributor

Anipik commented Nov 4, 2021

We will need to add the packaging changes here. here are the guidelines https://github.com/dotnet/runtime/blob/release/6.0/docs/project/library-servicing.md

@Anipik
Copy link
Contributor

Anipik commented Nov 9, 2021

@wfurt can you add the packaging changes here ?

@wfurt
Copy link
Member Author

wfurt commented Nov 9, 2021

Thanks @Anipik for the update. I'm swamped with servicing and I did not find time to work on this again.

@Anipik
Copy link
Contributor

Anipik commented Nov 10, 2021

Thanks @Anipik for the update. I'm swamped with servicing and I did not find time to work on this again.

welcome :)

@Anipik Anipik merged commit f30e7fa into dotnet:release/6.0 Nov 10, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Host Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants