Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maui iOS and MacCatalyst build steps #61068

Merged
merged 7 commits into from
Nov 2, 2021

Conversation

LoopedBard3
Copy link
Member

Added the Maui iOS and MacCatalyst build steps for the SOD performance testing (per dotnet/performance#2075). Includes addition of runtime replacement during build, building of necessary runtime files, building of iOS and MacCatalyst, piping of the built apps through the pipeline, and the helix items for the tests.

@ghost
Copy link

ghost commented Nov 1, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Added the Maui iOS and MacCatalyst build steps for the SOD performance testing (per dotnet/performance#2075). Includes addition of runtime replacement during build, building of necessary runtime files, building of iOS and MacCatalyst, piping of the built apps through the pipeline, and the helix items for the tests.

Author: LoopedBard3
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: -

Copy link
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a few comments. Also do you have a link to a completed run of this?

@LoopedBard3
Copy link
Member Author

Yes, there is a completed run, DM'd it.

Copy link
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoopedBard3 LoopedBard3 merged commit 06c2dba into dotnet:main Nov 2, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2021
@LoopedBard3 LoopedBard3 deleted the MauiiOSTestingClean branch January 20, 2022 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants