Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Disable failing System.Security.Cryptography tests due to http… #61102

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

radical
Copy link
Member

@radical radical commented Nov 2, 2021

@radical radical added the arch-wasm WebAssembly architecture label Nov 2, 2021
@ghost
Copy link

ghost commented Nov 2, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

…s://github.com//issues/61099

Author: radical
Assignees: -
Labels:

arch-wasm

Milestone: -

@bartonjs
Copy link
Member

bartonjs commented Nov 2, 2021

It looks like the tests used to be disabled by a higher-level thing:

<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Security.Cryptography.Primitives\tests\System.Security.Cryptography.Primitives.Tests.csproj" />

Since wasm does run some tests from Algorithms, and that'll be merged in soon, it does seem like attributes are the way to go.

@radical
Copy link
Member Author

radical commented Nov 2, 2021

Mono Product Build Linux arm64 release, and Libraries Build Linux_musl arm Release keep failing with Directory not empty.
@akoeplinger @steveisok

@steveisok
Copy link
Member

Mono Product Build Linux arm64 release, and Libraries Build Linux_musl arm Release keep failing with Directory not empty. @akoeplinger @steveisok

I believe that's a known issue b/c the workspaces do not get cleaned properly. I'd retry until it works or if you aren't patient, merge on red.

@radical radical merged commit e815a97 into dotnet:main Nov 2, 2021
@radical radical deleted the disable-sec-tests branch November 2, 2021 21:02
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants