-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0][mono][interp] Fix GetType called on ptr constrained to Nullable` (#6… #61305
[release/6.0][mono][interp] Fix GetType called on ptr constrained to Nullable` (#6… #61305
Conversation
…tnet#61020) * [interp] Fix GetType called on ptr constrained to Nullable` We were statically optimizing this call to return the actual constrained class type, which is incorrect for nullables, because boxing of a nullable (as part of the constrained call) actually creates an object with the type of the nullable's value (or null if there is no value). * Add test for GetType call on ptr constrained to nullable
Tagging subscribers to this area: @BrzVlad Issue DetailsBackport of #61020 to release/6.0 Fixes #61007 Customer ImpactFound by a customer, object.GetType() functions incorrectly on Nullable types in the interpreter. TestingManual RegressionYes, the regression was introduced this year. RiskLow. Regression introduced in net6.0
|
@lewing Re-created this PR manually since github actions seemed to fail the second time |
Tagging subscribers to this area: @BrzVlad Issue DetailsBackport of #61020 to release/6.0 Fixes #61007 Customer ImpactFound by a customer, object.GetType() functions incorrectly on Nullable types in the interpreter. TestingManual RegressionYes, the regression was introduced this year. RiskLow. Regression introduced in net6.0
|
/azp run runtime-staging, dotnet-linker-tests |
Azure Pipelines successfully started running 2 pipeline(s). |
Backport of #61020 to release/6.0
Customer Impact
Found by a customer, object.GetType() functions incorrectly on Nullable types in the interpreter.
Testing
Manual and CI
Regression
Yes, the regression was introduced this year.
Risk
Low. Regression introduced in net6.0