Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ref pack version to 6.0.0 for apicompat #61429

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Update the ref pack version to 6.0.0 for apicompat #61429

merged 2 commits into from
Nov 11, 2021

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Nov 10, 2021

Fixes #59533

@ghost
Copy link

ghost commented Nov 10, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #59533

Author: Anipik
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@safern
Copy link
Member

safern commented Nov 10, 2021

It seems like we don't do this on other release branches. Is this because we are servicing the ref pack this time?

<PreviousNetCoreAppPackageVersion>3.1.0</PreviousNetCoreAppPackageVersion>

Also, we need to update this on main as we are running API Compat against 5.0.0 and not 6.0.0:

<NetCoreAppLatestStableVersion>5.0</NetCoreAppLatestStableVersion>

@Anipik
Copy link
Contributor Author

Anipik commented Nov 10, 2021

It seems like we don't do this on other release branches. Is this because we are servicing the ref pack this time?

yeah thats the reason

@Anipik
Copy link
Contributor Author

Anipik commented Nov 11, 2021

@safern can you approve this one ?

@Anipik Anipik merged commit b1a832f into dotnet:release/6.0 Nov 11, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants