Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Don't run the JIT formatting job in CI #61485

Merged

Conversation

BruceForstall
Copy link
Member

The format job depends on the main branch of dotnet/jitutils (which isn't
properly versioned). Avoid future changes to jitutils causing a break in
servicing by disabling the formatting job.

Note that there is very little benefit to maintaining the formatting
CI requirement in servicing anyway.

The format job depends on the `main` branch of dotnet/jitutils (which isn't
properly versioned). Avoid future changes to jitutils causing a break in
servicing by disabling the formatting job.

Note that there is very little benefit to maintaining the formatting
CI requirement in servicing anyway.
@ghost
Copy link

ghost commented Nov 11, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

The format job depends on the main branch of dotnet/jitutils (which isn't
properly versioned). Avoid future changes to jitutils causing a break in
servicing by disabling the formatting job.

Note that there is very little benefit to maintaining the formatting
CI requirement in servicing anyway.

Author: BruceForstall
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: -

@BruceForstall
Copy link
Member Author

@dotnet/jit-contrib I propose to disable the JIT formatting job in the release/6.0 branch to prevent possible breaking changes later on, since the job depends on the jitutils main branch. If I get a PR signoff, I'll ask for approval.

@echesakov
Copy link
Contributor

I think it makes sense to disable the job for now.

But we also need either finish dotnet/jitutils#219 (since that was my PR - I probably should finish it) or find another way of publishing versioned jitutils artifacts.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Given this is infra. we just need to coordinate when this can be merged.

@safern safern merged commit b2f42fa into dotnet:release/6.0 Dec 15, 2021
@BruceForstall BruceForstall deleted the DisableJitFormatJobInRelease6 branch December 15, 2021 18:51
@ghost ghost locked as resolved and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants