Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Reduce the output from tests. #61593

Merged
merged 1 commit into from
Nov 18, 2021
Merged

[wasm] Reduce the output from tests. #61593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...nteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/MarshalTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,7 +911,7 @@ private static async Task<bool> MarshalTask(string helperMethodName, string help
$@"var t = App.call_test_method ('{helperMethodName}', [ {helperMethodArgs} ], 'i'); " +
"t.finally(result => { globalThis.__test_promise_completed = true; }); " +
"t.then(result => { globalThis.__test_promise_resolved = true; " + resolvedBody + " }); " +
"t.catch(e => { console.log(e); globalThis.__test_promise_failed = true; }); "
"t.catch(e => { globalThis.__test_promise_failed = true; }); "
);

await Task.Delay(1);
Expand Down
6 changes: 3 additions & 3 deletions src/mono/wasm/runtime/driver.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,12 +485,12 @@ mono_wasm_load_runtime (const char *unused, int debug_level)
#endif

#ifdef DEBUG
monoeg_g_setenv ("MONO_LOG_LEVEL", "debug", 0);
monoeg_g_setenv ("MONO_LOG_MASK", "gc", 0);
// monoeg_g_setenv ("MONO_LOG_LEVEL", "debug", 0);
// monoeg_g_setenv ("MONO_LOG_MASK", "gc", 0);
// Setting this env var allows Diagnostic.Debug to write to stderr. In a browser environment this
// output will be sent to the console. Right now this is the only way to emit debug logging from
// corlib assemblies.
monoeg_g_setenv ("COMPlus_DebugWriteToStdErr", "1", 0);
// monoeg_g_setenv ("COMPlus_DebugWriteToStdErr", "1", 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should revisit the way this works and send Debug.* output to the proper js console

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for reference this is what it does

runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/DebugProvider.Unix.cs

Line 42 in 57bfe47

if (s_shouldWriteToStdErr)

#endif
// When the list of app context properties changes, please update RuntimeConfigReservedProperties for
// target _WasmGenerateRuntimeConfig in WasmApp.targets file
Expand Down