Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload dasm files as artifacts for "asmdiffs pipeline" #61700

Merged
merged 13 commits into from
Nov 18, 2021

Conversation

kunalspathak
Copy link
Member

@kunalspathak kunalspathak commented Nov 16, 2021

For asmdiffs pipeline, upload the top N improvement/regression .dasm files so the developer can continue the investigation instead of building and producing those .dasm files on their local machine.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 16, 2021
@ghost
Copy link

ghost commented Nov 16, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: kunalspathak
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@kunalspathak kunalspathak marked this pull request as ready for review November 17, 2021 21:42
@kunalspathak
Copy link
Member Author

@dotnet/jit-contrib , @BruceForstall

@kunalspathak kunalspathak changed the title Upload dasm files as artifacts Upload dasm files as artifacts for "asmdiffs pipeline" Nov 17, 2021
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just a couple nits

src/coreclr/scripts/superpmi.py Outdated Show resolved Hide resolved
src/coreclr/scripts/superpmi_asmdiffs.py Show resolved Hide resolved
src/coreclr/scripts/superpmi_asmdiffs.py Outdated Show resolved Hide resolved
@kunalspathak
Copy link
Member Author

Looks good; just a couple nits

Fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants