-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] workaround test results corruption #61841
[wasm] workaround test results corruption #61841
Conversation
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue Details
In hope that it fixes or surfaces more the issue #61749
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
In hope that it fixes or surfaces more the issue #61749
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once the test changes are reverted
|
Work in progress here dotnet/xharness#771 |
This reverts commit 5102ad2.
Will need new nuget binaries from dotnet/xharness#771 |
/azp run runtime-manual |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-manual |
Azure Pipelines successfully started running 1 pipeline(s). |
@radical @maraf @lewing I think this fixes XML corruption problem for WASM. @premun I know that you are working on bumping all other dependencies too in #61668 shall we wait for that instead of merging it here ? |
Please merge it here |
You can ignore the Wasm/Windows/AOT tests. |
You can ignore the Wasm/Windows/WBT tests also. I am disabling them in #61937 . |
WASM EXIT
. This is bit pointless because it goes into the same WS buffer, on the other hand, we know that we reached that point before the browser process was stopped.Fixes #61749