-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type memory maps with placeholders #61933
Type memory maps with placeholders #61933
Conversation
Use TYP_UNDEF (as TYP_MEM) for "first field"-like maps and TYP_UNKNOWN (as TYP_HEAP) for the heaps themselves. This will enable the type validation logic to be more precise. For now, just assert that the heap is always updated with the properly typed VNs.
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsUse This will enable the type validation logic to be more precise. For now though, just assert that the heap is always updated with the properly typed VNs. No diffs are expected...
|
@dotnet/jit-contrib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Use TYP_UNDEF (as TYP_MEM) for "first field"-like maps and TYP_UNKNOWN (as TYP_HEAP) for the heaps themselves. This will enable the type validation logic to be more precise. For now, just assert that the heap is always updated with the properly typed VNs.
Use
TYP_UNDEF
(asTYP_MEM
) for "first field"-like maps andTYP_UNKNOWN
(asTYP_HEAP
) for the heaps themselves.This will enable the type validation logic to be more precise. For now though, just assert that the heap is always updated with the properly typed VNs.
Sample from the new dump showcasing the now-more-apparent hierarchy of maps:
No diffs.
Part of #58312.