-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a github action to sync shared source from aspnetcore #61999
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Check the code is in sync | ||
| $changed = (select-string "nothing to commit" artifacts\status.txt).count -eq 0 | ||
| return $changed | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| name: AspNetCore->Runtime Code Sync | ||
| on: | ||
| # Manual run | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: write | ||
| issues: write | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| compare_repos: | ||
| # Comment out this line to test the scripts in a fork | ||
| if: github.repository == 'dotnet/runtime' | ||
| name: Sync Code | ||
| runs-on: windows-latest | ||
| steps: | ||
| - name: Checkout aspnetcore | ||
| uses: actions/[email protected] | ||
| with: | ||
| # Test this script using changes in a fork | ||
| repository: 'dotnet/aspnetcore' | ||
| path: aspnetcore | ||
| ref: main | ||
| - name: Checkout runtime | ||
| uses: actions/[email protected] | ||
| with: | ||
| # Test this script using changes in a fork | ||
| repository: 'dotnet/runtime' | ||
| path: runtime | ||
| ref: main | ||
| - name: Copy | ||
| shell: cmd | ||
| working-directory: .\aspnetcore\src\Shared\runtime\ | ||
| env: | ||
| RUNTIME_REPO: d:\a\runtime\runtime\runtime\ | ||
| run: CopyToRuntime.cmd | ||
| - name: Diff | ||
| shell: cmd | ||
| working-directory: .\runtime\ | ||
| run: | | ||
| mkdir ..\artifacts | ||
| git status > ..\artifacts\status.txt | ||
| git diff > ..\artifacts\diff.txt | ||
| - uses: actions/upload-artifact@v1 | ||
| with: | ||
| name: results | ||
| path: artifacts | ||
| - name: Check | ||
| id: check | ||
| shell: pwsh | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| $changed = .\runtime\.github\workflows\aspnetcore-sync-checkdiff.ps1 | ||
| echo "::set-output name=changed::$changed" | ||
| - name: Send PR | ||
| if: steps.check.outputs.changed == 'true' | ||
| # https://github.com/marketplace/actions/create-pull-request | ||
| uses: dotnet/actions-create-pull-request@v3 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| path: .\runtime | ||
| commit-message: 'Sync shared code from aspnetcore' | ||
| title: 'Sync shared code from aspnetcore' | ||
| body: 'This PR was automatically generated to sync shared code changes from aspnetcore. Fixes https://github.com/dotnet/aspnetcore/issues/18943' | ||
| labels: area-System.Net.Http | ||
| base: main | ||
| branch: github-action/sync-aspnetcore | ||
| branch-suffix: timestamp |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this extra file needed? We could just inline this command in the gh action?
Also, I wonder if using
git diffwould be easier? Something likeThe only issue I see with
git diffare untracked files, so we would need to rungit add -N .before running the command. Just an idea to consider.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the aspnetcore version of this file did a lot more to open and comment on the github issue. Inlining just this part might be easier now.
https://github.com/dotnet/aspnetcore/blob/main/.github/workflows/ReportDiff.ps1