Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid switching GC mode in COM's HasValidTarget #62066

Merged
merged 2 commits into from
Nov 26, 2021

Conversation

am11
Copy link
Member

@am11 am11 commented Nov 26, 2021

Fixes #62063.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 26, 2021
@am11
Copy link
Member Author

am11 commented Nov 26, 2021

cc @jkotas, can we run the gc-standalone pipeline for this PR, as it is the one where failing test was discovered? (this pipeline is failing for some time)

@jkotas
Copy link
Member

jkotas commented Nov 26, 2021

/azp run gc-standalone

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@jkotas
Copy link
Member

jkotas commented Nov 26, 2021

can we run the gc-standalone pipeline for this PR

Triggered

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@am11
Copy link
Member Author

am11 commented Nov 26, 2021

COM wrapper test is not failing anymore: https://dev.azure.com/dnceng/public/_build/results?buildId=1487089&view=ms.vss-test-web.build-test-results-tab (compared with the previous run https://dev.azure.com/dnceng/public/_build/results?buildId=1486145&view=ms.vss-test-web.build-test-results-tab).

For remaining failures, I have opened #62083 and #62084. RuntimeConfiguration test is a new one, so I reported to @AaronRobinsonMSFT directly: #61950 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Interop-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interop ComWrappersTests failures
2 participants