[release/6.0] Fix System.Object serialization with custom number handling #62193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
eiriktsarpalis,
layomia and
steveharter
as code owners
|
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsBackport of #62020 to release/6.0 /cc @eiriktsarpalis Customer ImpactTestingRisk
|
eiriktsarpalis
added
the
Servicing-consider
|
Servicing approved over email. |
eiriktsarpalis
added
api-approved
stephentoub
approved these changes
Dec 1, 2021
safern
removed
the
NO-MERGE
|
Closing and reopening to trigger CI again. |
steveharter
approved these changes
Dec 15, 2021
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/Object.ReadTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/Object.ReadTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/Object.WriteTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/Object.WriteTests.cs
Outdated
Show resolved
Hide resolved
|
@eiriktsarpalis @ericstj do we need to address feedback here before 6.0.2 cutoff? |
|
Sure, I can help with that since @eiriktsarpalis is out. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #62020 to release/6.0
/cc @eiriktsarpalis
Customer Impact
Addresses a customer-reported regression concerning serialization of
new object()instances when used in conjunction with custom number handling. The regression was introduced by #54436 which refactored polymorphic serialization forobjecttypes but failed to account for custom number handling.Testing
Added regression tests that check for polymorphic serialization in custom number handling scenaria.
Risk
Low. This change impacts a rare corner case (serializing
new object()instances).