[release/5.0] Fixes #62167. WriteAsync may truncate data if called after .Advance(int) #62350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… called after an .Advance(int)
BrennanConroy
added
the
Servicing-consider
halter73
approved these changes
Dec 3, 2021
halter73
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #62306 to release/5.0
/cc @BrennanConroy @Kuinox
Customer Impact
Customer reported issue. This can result in corrupted data (missing bytes in the middle of a Read) when using pipes with a mix of
GetSpan()+Advance()andWriteAsync()Testing
New test was written for the scenario, current test coverage gives high confidence no regressions will occur.
Risk
Low. The fix is well understood and very little code change.