Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notepad window title is uppercase on Windows 11 #62487

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

danmoseley
Copy link
Member

Fix failure seen in #62396

@ghost
Copy link

ghost commented Dec 7, 2021

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix failure seen in #62396

Author: danmoseley
Assignees: -
Labels:

area-System.Diagnostics.Process

Milestone: -

@danmoseley
Copy link
Member Author

Overlooked because its outerloop perhaps.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for fixing it!

@danmoseley danmoseley merged commit 2ecc0e2 into dotnet:main Dec 7, 2021
@danmoseley danmoseley deleted the notepad branch December 7, 2021 16:55
danmoseley added a commit to jozkee/runtime that referenced this pull request Dec 30, 2021
danmoseley added a commit that referenced this pull request Dec 31, 2021
)

* Move NoInt32OverflowInTheBufferingLogic to OuterLoop and address pending feedback (#60606)

* Don't create multiple large files at the same time (#62519)

* move existing large file tests into a separate type (no code changes)

* don't run the large file tests in parallel

* use FileOptions.DeleteOnClose to ensure that each test removes it's own file

use single large file to test File.ReadAllBytes and ile.ReadAllBytesAsync for both limits

* Fix DisableParallelization build issue

* Apply suggestions from code review

Co-authored-by: Adam Sitnik <[email protected]>

* Update src/libraries/System.IO.FileSystem/tests/LargeFileTests.cs

Co-authored-by: Adam Sitnik <[email protected]>

* Notepad with uppercase (#62487)

Co-authored-by: Adam Sitnik <[email protected]>
Co-authored-by: Dan Moseley <[email protected]>
@ghost ghost locked as resolved and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants