Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix createdump failure on MacOS Monterey version 12.0.1. #62548

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

mikem8361
Copy link
Member

@mikem8361 mikem8361 commented Dec 8, 2021

Customer Impact

Customers (like VS4Mac and the dev in the below issue) fail to collect dumps on MacOS Monterey.

Details

Fails looking for the symbol _dyld_all_image_infos in dylinker. The fix is to fallback to searching all the symbols after searching the "external" symbols.

Issue: #62181

Testing

Local testing. The VS4Mac team has verified.

Risk

Low since it only affects createdump and managed debugging (DBI/DAC).

Fails looking for the symbol _dyld_all_image_infos in dylinker. The fix is to fallback to searching all the symbols after searching the "external" symbols.

Issue: dotnet#62181
@mikem8361 mikem8361 added this to the 6.0.x milestone Dec 8, 2021
@mikem8361 mikem8361 self-assigned this Dec 8, 2021
@ghost
Copy link

ghost commented Dec 8, 2021

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Customer Impact

Customers (like VS4Mac and the dev in the below issue) fail to collect dumps on MacOS Monterey.

Details

Fails looking for the symbol _dyld_all_image_infos in dylinker. The fix is to fallback to searching all the symbols after searching the "external" symbols.

Issue: #62181

Testing

Local testing. Will ask VS4Mac to verify.

Risk

Low since it only affects createdump and managed debugging (DBI/DAC).

Author: mikem8361
Assignees: mikem8361
Labels:

area-Diagnostics-coreclr

Milestone: 6.0.x

@mikem8361 mikem8361 added the Servicing-consider Issue for next servicing release review label Dec 10, 2021
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We can take for consideration in 6.0.x

@safern
Copy link
Member

safern commented Dec 15, 2021

@jeffschwMSFT can I merge this or still has to go over tactics?

@jeffschwMSFT
Copy link
Member

Have not yet sought approval

@mikem8361
Copy link
Member Author

mikem8361 commented Dec 15, 2021 via email

@safern
Copy link
Member

safern commented Dec 17, 2021

Approved on tactics and over email.

@safern safern added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 17, 2021
@safern safern merged commit f76382a into dotnet:release/6.0 Dec 17, 2021
@mikem8361 mikem8361 deleted the macsyms60 branch January 4, 2022 20:32
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants