-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setting timestamp on Windows on readonly files #62638
Conversation
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsFix #62602 All other attribute/timestamp operations go through GetFileAttributesEx/SetFileAttributes and work fine. Curiously this is a bug back to .NET Framework.
|
src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Windows.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subject to my question on the issue, LGTM.
a0f4820
to
463f536
Compare
@dotnet/dnceng any idea about this
does this go through @MattGal 's patent retry scheme? |
I'd expect the variables to be set here, checking this out. It is still theoretically possible to fully fail, too (all I added was delay and retry) |
@danmoseley the binlog definitely contains the variables and it should definitely be a new enough SDK. It didn't log the retries either, this may have just been some unusual catastrophic response? If it keeps up we can pursue with AzDO packaging folks to see what happened on https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-buildservices/ in that time. |
Hmm, NuGet issues on another leg also
|
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1588621425 |
@adamsitnik backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: fix datetime
.git/rebase-apply/patch:127: trailing whitespace.
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M src/libraries/System.IO.FileSystem/tests/Base/BaseGetSetTimes.cs
M src/libraries/System.IO.FileSystem/tests/Directory/GetSetTimes.cs
M src/libraries/System.IO.FileSystem/tests/DirectoryInfo/GetSetTimes.cs
M src/libraries/System.IO.FileSystem/tests/File/GetSetTimes.cs
M src/libraries/System.IO.FileSystem/tests/FileInfo/GetSetTimes.cs
M src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Windows.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Windows.cs
Auto-merging src/libraries/System.IO.FileSystem/tests/FileInfo/GetSetTimes.cs
Auto-merging src/libraries/System.IO.FileSystem/tests/File/GetSetTimes.cs
Auto-merging src/libraries/System.IO.FileSystem/tests/DirectoryInfo/GetSetTimes.cs
Auto-merging src/libraries/System.IO.FileSystem/tests/Directory/GetSetTimes.cs
Auto-merging src/libraries/System.IO.FileSystem/tests/Base/BaseGetSetTimes.cs
CONFLICT (content): Merge conflict in src/libraries/System.IO.FileSystem/tests/Base/BaseGetSetTimes.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix datetime
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
# Conflicts: # src/libraries/System.IO.FileSystem/tests/Base/BaseGetSetTimes.cs
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
) * Fix setting timestamp on Windows on readonly files (#62638) # Conflicts: # src/libraries/System.IO.FileSystem/tests/Base/BaseGetSetTimes.cs * make it compile * fix build Co-authored-by: Dan Moseley <[email protected]>
Fix #62602
All other attribute/timestamp operations go through GetFileAttributesEx/SetFileAttributes and work fine.
Curiously this is a bug back to .NET Framework.