Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Add runtime-community.yml pipeline and add s390x job #62808

Merged
merged 6 commits into from
Jan 3, 2022

Conversation

directhex
Copy link
Contributor

@directhex directhex commented Dec 14, 2021

Backport of #60255, #60351, #60552, #57566, #58952 to release/6.0

/cc @uweigand

Customer Impact

IBM have released .NET 6 on IBM Z (s390x architecture) as part of the RHEL 8 release, but currently have no way to CI the 6.0 branch, only main. This change enables them to test changes in time for fixes to happen

Testing

It enables a whole CI lane, so lots of testing.

Risk

Low, this should only affect IBM (and add a small overhead for building the additional lane). The runtime-community lanes should fail green so it shouldn't risk breaking our builds if a test run fails.

@ghost
Copy link

ghost commented Dec 14, 2021

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #60255 and #60351 to release/6.0

Customer Impact

IBM have released .NET 6 on IBM Z (s390x architecture) as part of the RHEL 8 release, but currently have no way to CI the 6.0 branch, only main. This change enables them to test changes in time for fixes to happen

Testing

It enables a whole CI lane, so lots of testing.

Risk

Low, this should only affect IBM (and add a small overhead for building the additional lane). The runtime-community lanes should fail green so it shouldn't risk breaking our builds if a test run fails.

Author: directhex
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@directhex directhex added the Servicing-consider Issue for next servicing release review label Dec 14, 2021
@directhex directhex added this to the 6.0.x milestone Dec 14, 2021
@directhex
Copy link
Contributor Author

@akoeplinger I think I missed something, the s390x branch was skipped by runtime-community.yml. Any obvious signs?

@danmoseley
Copy link
Member

@directhex when ready could you please send mail direct to tactics for approval? since M2's are on vac in some cases.

@directhex
Copy link
Contributor Author

Yeah, held off on sending an email until I got the yml figured

dotnet#60552)

It was missed where we set a default value for that variable.

(cherry picked from commit 157a8b5)
)

Co-authored-by: Stefan Schulze Frielinghaus <[email protected]>
(cherry picked from commit 616ace3)
@dotnet dotnet deleted a comment from azure-pipelines bot Dec 16, 2021
@dotnet dotnet deleted a comment from akoeplinger Dec 16, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot Dec 16, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot Dec 16, 2021
This allows consuming the dotnet host that was just built instead of relying on a downloaded one.
We need to move the `host` subset build before the `libs` subset so that the artifacts are available before externals.csproj runs.

(cherry picked from commit cab3a63)
@directhex
Copy link
Contributor Author

/azp run runtime-community

@dotnet dotnet deleted a comment from azure-pipelines bot Dec 16, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@directhex directhex added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 17, 2021
@directhex
Copy link
Contributor Author

Approved by Steve Carroll via email

@safern safern merged commit 2282b00 into dotnet:release/6.0 Jan 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants