[release/6.0] Fixing regression for AuthType.Anonymous which leads to a NullReferenceException be thrown. #62824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014 |
buyaa-n
reviewed
Dec 15, 2021
src/libraries/System.DirectoryServices.Protocols/src/System.DirectoryServices.Protocols.csproj
Show resolved
Hide resolved
buyaa-n
approved these changes
Dec 15, 2021
leecow
added
Servicing-approved
ericstj
reviewed
Dec 16, 2021
| var connection = new LdapConnection("server"); | ||
| connection.AuthType = AuthType.Anonymous; | ||
| // When calling Bind we make sure that the exception thrown is not that there was a NullReferenceException | ||
| // trying to retrive a null password's lenght, but instead an LdapException given the server cannot be reached. |
There was a problem hiding this comment.
Just noticed a typo here: lenght
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #62807 to release/6.0
/cc @joperezr
Customer Impact
This PR is fixing a customer reported regression on this issue: #61683
The regression is present only on NuGet package System.DirectoryServices.Protocols version 6.0.0
The problem here is that if a consumer is running on Linux, and tries to Bind to a LDAP server using
AuthType.Anonymousthen we will throw aNullReferenceExceptiondue to a bug we have where we try to de-reference the user's password which in Anonymous case, will be null. There is no good workaround for this for using Anonymous AuthType today, other than downgrading the NuGet package version to 5.0.1 which doesn't have the regression.Testing
We've added unit test for regression coverage, and the fix has been validated by the customer that first reported the issue and said it fixed the issue for them. (cc. @JasonDebug)
Risk
Low. This is fixing a regression from 5.0->6.0 and currently we have no good workaround to avoid throwing NullReferenceException. The risks here are basically the same as shipping a new version of any of our NuGet packages.