Delete NativeAOT-specific CoreLib string resources #63129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
requested review from
marek-safar and
MichalStrehovsky
as code owners
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue Detailsnull
|
- Fix missing localization of resource strings - Delete duplicate resource strings where possible - Delete internal or redundant messages
MichalStrehovsky
approved these changes
Dec 25, 2021
| // with a stub that throws an InvalidProgramException | ||
| if (method.IsUnmanagedCallersOnly && (flags & CORINFO_CALLINFO_FLAGS.CORINFO_CALLINFO_LDFTN) == 0) | ||
| { | ||
| ThrowHelper.ThrowInvalidProgramException(ExceptionStringID.InvalidProgramUnmanagedCallersOnly, method); |
There was a problem hiding this comment.
What will happen if someone tries to call UnmanagedCallersOnly method from managed code after this?
There was a problem hiding this comment.
I have pushed commit to print same error message as the JIT-based version of the runtime.
marek-safar
approved these changes
Dec 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.