[DllImportGenerator] Update buffer size field for custom marshalling #63316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinor-fung
added
area-System.Runtime.InteropServices
source-generator
ghost
assigned 
jkoritzinsky
approved these changes
Jan 3, 2022
danmoseley
reviewed
Jan 4, 2022
| <value>A type that supports marshalling from managed to native using a caller-allocated buffer should also support marshalling from managed to native where using a caller-allocated buffer is impossible.</value> | ||
| </data> | ||
| <data name="CallerAllocMarshallingShouldSupportAllocatingMarshallingFallbackMessage" xml:space="preserve"> | ||
| <value>Native type '{0}' has a constructor taking a caller-allocated buffer, but does not support marshalling in scenarios where using a caller-allocated buffer is impossible</value> |
There was a problem hiding this comment.
Suggested change
| <value>Native type '{0}' has a constructor taking a caller-allocated buffer, but does not support marshalling in scenarios where using a caller-allocated buffer is impossible</value> | |
| <value>Native type '{0}' has a constructor taking a caller-allocated buffer, but does not support marshalling in scenarios where using a caller-allocated buffer is impossible.</value> |
There was a problem hiding this comment.
Since it is a single sentence, I believe the message should not have the period (RS1032).
danmoseley
reviewed
Jan 4, 2022
src/libraries/System.Runtime.InteropServices/gen/DllImportGenerator/Resources.resx
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Jan 4, 2022
| @@ -708,7 +708,8 @@ public Native(S s) | |||
|
|
|||
| public S ToManaged() => new S { b = i != 0 }; | |||
|
|
|||
| public const int StackBufferSize = 1; | |||
| public const int BufferSize = 1; | |||
| public const bool RequiresStackBuffer = true; | |||
There was a problem hiding this comment.
Perhaps a test with RequiresStackBuffer = false;?
…rator/Resources.resx Co-authored-by: Dan Moseley <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update from #60374.
This is still always using stackalloc, so
RequiresStackBufferis not actually checked yet.@AaronRobinsonMSFT @jkoritzinsky