-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] WinHttp: always read HTTP/2 streams to the end #63346
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #62870 to release/6.0 /cc @antonfirsov Customer ImpactTestingRisk
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #62870 to release/6.0 Fixes #60291 /cc @antonfirsov Customer Impact#60291 is a bug in WinHttpHandler that breaks the grpc + WinHttpHandler + IIS scenario. This prevents running/debugging grpc code on .NET Framework using Visual Studio + IIS Express which is an important customer scenario. Testing
RiskLow.
|
Note: This PR was insufficient as it forgot NuGet package authoring. The fix was truly released in PR #65523 as part of 6.0.4 (which is WinHttpHandler 6.0.1 to make versioning even more confusing) |
Backport of #62870 to release/6.0
Fixes #60291
/cc @antonfirsov
Customer Impact
#60291 is a bug in WinHttpHandler that prevents running/debugging gRPC code on .NET Framework using Visual Studio + IIS Express which is an important customer scenario for dotnet/core#5713. It can probably also manifest in production environments with servers other than Kestrel.
Testing
Risk
Low. Impacts only specific HTTP/2 cases in WinHttpHandler.