Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] WinHttp: always read HTTP/2 streams to the end #63346

Merged
merged 3 commits into from
Jan 7, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 4, 2022

Backport of #62870 to release/6.0

Fixes #60291

/cc @antonfirsov

Customer Impact

#60291 is a bug in WinHttpHandler that prevents running/debugging gRPC code on .NET Framework using Visual Studio + IIS Express which is an important customer scenario for dotnet/core#5713. It can probably also manifest in production environments with servers other than Kestrel.

Testing

  • Unit tests have been added
  • End to end validation of the fix has been done with Visual Studio + IIS Express

Risk

Low. Impacts only specific HTTP/2 cases in WinHttpHandler.

@ghost
Copy link

ghost commented Jan 4, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #62870 to release/6.0

/cc @antonfirsov

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net

Milestone: -

@antonfirsov antonfirsov added Servicing-consider Issue for next servicing release review area-System.Net.Http and removed area-System.Net labels Jan 4, 2022
@ghost
Copy link

ghost commented Jan 4, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #62870 to release/6.0

Fixes #60291

/cc @antonfirsov

Customer Impact

#60291 is a bug in WinHttpHandler that breaks the grpc + WinHttpHandler + IIS scenario. This prevents running/debugging grpc code on .NET Framework using Visual Studio + IIS Express which is an important customer scenario.

Testing

  • Unit tests have been added
  • End to end validation of the fix has been done with Visual Studio + IIS Express

Risk

Low.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, area-System.Net.Http

Milestone: -

@antonfirsov antonfirsov requested a review from a team January 4, 2022 18:03
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 4, 2022
@leecow leecow added this to the 6.0.2 milestone Jan 4, 2022
@karelz karelz requested a review from JamesNK January 6, 2022 11:00
@danmoseley danmoseley merged commit 201673a into release/6.0 Jan 7, 2022
@danmoseley danmoseley deleted the backport/pr-62870-to-release/6.0 branch January 7, 2022 16:37
@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2022
@karelz
Copy link
Member

karelz commented Mar 22, 2022

Note: This PR was insufficient as it forgot NuGet package authoring. The fix was truly released in PR #65523 as part of 6.0.4 (which is WinHttpHandler 6.0.1 to make versioning even more confusing)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants