Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DllImportGenerator] Remove DLLIMPORTGENERATOR_ENABLED define option #63464

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

elinor-fung
Copy link
Member

Remove DLLIMPORTGENERATOR_ENABLED define and associated code fix. Now that we have the forwarding via partial extern in and we've been able to switch runtime libraries over to it, this define is no longer useful.

@AaronRobinsonMSFT @jkoritzinsky

@elinor-fung elinor-fung added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels Jan 6, 2022
@elinor-fung elinor-fung added this to the 7.0.0 milestone Jan 6, 2022
@ghost ghost assigned elinor-fung Jan 6, 2022
@elinor-fung elinor-fung changed the title [DllImportGenerator] Remove DLLIMPORTGENERATOR_ENABLED define [DllImportGenerator] Remove DLLIMPORTGENERATOR_ENABLED define option Jan 6, 2022
@elinor-fung elinor-fung merged commit b0685e1 into dotnet:main Jan 6, 2022
@elinor-fung elinor-fung deleted the removePreprocessorDefine branch January 6, 2022 22:10
@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants