Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Debuger tests refactor 63667 #63730

Merged
merged 8 commits into from
Mar 30, 2022

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jan 13, 2022

Fixes #63667, see the Issue for description.
The PR also adds logging the error thrown in RuntimeGetPropertiesInternal as it was the information I frequently lacked when debugging.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Jan 13, 2022
@ilonatommy ilonatommy self-assigned this Jan 13, 2022
@ghost
Copy link

ghost commented Jan 13, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #63667, see the Issue for description.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@ilonatommy ilonatommy requested a review from lewing March 23, 2022 15:49
@ilonatommy
Copy link
Member Author

/azp run runtime-staging

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy ilonatommy requested a review from radical March 25, 2022 14:42
@lewing lewing merged commit cbf3f9c into dotnet:main Mar 30, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm][debugger] Refactor tests to use existing, complex test classes
3 participants