Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes for required members #64287

Merged
merged 4 commits into from
Jan 27, 2022

Conversation

333fred
Copy link
Member

@333fred 333fred commented Jan 25, 2022

Closes #64248.

Relates to test plan dotnet/roslyn#57046

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Jan 25, 2022

Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #64248.

Author: 333fred
Assignees: 333fred
Labels:

area-System.Runtime.CompilerServices

Milestone: -

@stephentoub
Copy link
Member

This also needs:

Also the ifdef for corelib is only necessary if we expect these files to be included into other assemblies beyond corelib.

@333fred
Copy link
Member Author

333fred commented Jan 25, 2022

Also the ifdef for corelib is only necessary if we expect these files to be included into other assemblies beyond corelib.

I somewhat expect that this attribute will be copied by customers, so I'd prefer to keep them.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@stephentoub stephentoub merged commit 6233735 into dotnet:main Jan 27, 2022
@333fred 333fred deleted the required-members-attributes branch January 27, 2022 19:35
@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: RequiredMemberAttribute and NoRequiredMembersAttribute
2 participants