Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Metrics UpDownCounter #64365

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Add Metrics UpDownCounter #64365

merged 3 commits into from
Jan 28, 2022

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jan 27, 2022

Fixes #63648

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned tarekgh Jan 27, 2022
@tarekgh tarekgh added this to the 7.0.0 milestone Jan 27, 2022
@tarekgh
Copy link
Member Author

tarekgh commented Jan 27, 2022

CC @reyang @cijothomas @noahfalk

@tarekgh tarekgh requested a review from noahfalk January 27, 2022 01:42
@tarekgh
Copy link
Member Author

tarekgh commented Jan 27, 2022

The CI failure is unrelated and tracked with the issue #64389

noahfalk
noahfalk approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/Meter.cs Outdated Show resolved Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/Meter.cs Outdated Show resolved Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/Meter.cs Outdated Show resolved Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/Meter.cs Outdated Show resolved Hide resolved
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/Meter.cs Outdated Show resolved Hide resolved
...ibraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/UpDownCounter.cs Outdated Show resolved Hide resolved
...ibraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/UpDownCounter.cs Outdated Show resolved Hide resolved
...ibraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/UpDownCounter.cs Outdated Show resolved Hide resolved
...ibraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/UpDownCounter.cs Outdated Show resolved Hide resolved
...ibraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/UpDownCounter.cs Outdated Show resolved Hide resolved
@tarekgh tarekgh merged commit c264b26 into dotnet:main Jan 28, 2022
@tarekgh tarekgh deleted the AddMetricsUpDownCounter branch January 28, 2022 02:41
@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noahfalk noahfalk noahfalk approved these changes

@reyang reyang reyang approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.Diagnostics.Metric new-api-needs-documentation
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Support Metrics UpDownCounter instrument
3 participants
@tarekgh @noahfalk @reyang