Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable EC file import tests #64397

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

bartonjs
Copy link
Member

Mitigates #64389

@ghost
Copy link

ghost commented Jan 27, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Mitigates #64389

Author: bartonjs
Assignees: -
Labels:

area-System.Security

Milestone: -

@vcsjones
Copy link
Member

Does this need to be applied to the Pem ones as well?

They are modeled similarly as the ones you disabled. Is it possible they will be problematic for whatever reason the ones you disabled are?

@bartonjs
Copy link
Member Author

Does this need to be applied to the Pem ones as well?

Per local testing, disabling just these two types (ultimately the base class that powers them) was enough. It'll get CI off the floor and let my compatriots in the OS group figure out what went wrong.

@stephentoub stephentoub merged commit 10df829 into dotnet:main Jan 27, 2022
@bartonjs
Copy link
Member Author

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1759096282

@bartonjs bartonjs deleted the avoid_cng_lockup branch January 28, 2022 00:19
@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants