Update mac Helix queues #64565
Update mac Helix queues #64565
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| - OSX.1014.Amd64.Open | ||
| - ${{ if or(ne(parameters.jobParameters.isExtraPlatforms, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}: | ||
| - OSX.1015.Amd64.Open | ||
| - OSX.1200.Amd64.Open |
There was a problem hiding this comment.
Since we no longer have a diff between extra platforms for OSX_x64 I would recommend removing the OSX_64 legs that run libraries tests:
There was a problem hiding this comment.
I'm not opposed, but I'd rather do it in a different PR, in case it causes unrelated problems.
There was a problem hiding this comment.
What worries me to delay it to a different PR is that usually those TODOs get delayed or slip on the backlog and we will just be wasting resources that are useful on the extra-platforms run.
There was a problem hiding this comment.
Or at least if it is a subsequent PR you'll do in the next day or so, I don't mind.
|
@elinor-fung @AaronRobinsonMSFT @jkoritzinsky would you mind looking at this PR? After I upgraded the tests to use the latest Mac machines, it looks like some DllImport unit tests are failing |
|
It looks like that test case is relying on setting Maybe this is that macOS security thing where they purge |
|
Sounds good, I'll skip the test. |
|
Is the OSX failure related? If not, is this ready to go? |
|
Only the OSX.1014.Amd64 queue was removed so we could keep the 10.15 ones. |
|
FYI there is this overview - https://github.com/dotnet/core-eng/wiki/Mobile-devices-for-.NET-testing (there are almost all OSX queues listed there, not just mobile) The 12.00 is the largest queue by far with zero load, so we should definitely move some of the 10.14 workloads there (if possible). 10.15 is the most stressed queue at the moment if I am not mistaken. |
|
Btw we have a related discussion ongoing - do we need docker on OSX queues? |
|
@tommcdon It looks like a few |
|
@agocke can we disable the test and open an issue in order to unblock other PRs? |
|
@safern Yes, I didn't realize other PRs were failing. I'll do this immediately. |
|
This is failing every PR so I don't think it can get worse. I'm going to merge now. |
ghost
locked as resolved and limited conversation to collaborators
No description provided.