Another size estimate fix for movs
#64826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThis, time, we were overestimating Another small step towards We are expecting a small number of positive diffs.
|
SingleAccretion
commented
Feb 4, 2022
Comment on lines
-2783
to
+2789
| // 64-bit immediates are only supported on mov r64, imm64 | ||
| // As per manual: | ||
| // Support for 64-bit immediate operands is accomplished by expanding | ||
| // the semantics of the existing move (MOV reg, imm16/32) instructions. | ||
| if ((valSize > sizeof(INT32)) && (ins != INS_mov)) | ||
| valSize = sizeof(INT32); | ||
| #else | ||
| // occasionally longs get here on x86 | ||
| // mov reg, imm64 is the only opcode which takes a full 8 byte immediate | ||
| // all other opcodes take a sign-extended 4-byte immediate | ||
| noway_assert(valSize <= sizeof(INT32) || !id->idIsCnsReloc()); |
There was a problem hiding this comment.
mov reg, imm64 does not get here as this is for the M-format instructions, so there is no need to check for it.
Also, this comment is intentionally copied verbatim from emitInsSizeAM.
SingleAccretion
force-pushed
the
Fix-Size-Estimate-For-Movs
branch
from
25fe641
to
1a2400a
Compare
|
@dotnet/jit-contrib |
BruceForstall
approved these changes
Feb 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time, we were overestimating
mov [addr], imm(by 4 bytes).Another small step towards
CLS_VARdeletion.A small number of positive diffs.