Do not number partial definitions and ARGPLACE nodes
#64898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThree changes in this set:
Overall, we are saving a little under No diffs are expected.
|
SingleAccretion
commented
Feb 7, 2022
| const GenTree* nextNode = lcl->gtNext; | ||
| const LclVarDsc* varDsc = lvaGetDesc(lcl); | ||
|
|
||
| assert((nextNode->gtOper == GT_ADDR && nextNode->AsOp()->gtOp1 == lcl) || |
There was a problem hiding this comment.
Didn't replicate this assert as I don't find it useful - yes, we will see some locals under ADDRs here, but that's just how the IR is.
|
@dotnet/jit-contrib |
Do not number "partial definitions" - it is simply wasted work.
For ARGPLACE nodes, they will be overwritten when numbering the call. For nodes that do not produce values, they serve no purpose, and just waste memory. Also, delete RET_EXPR/FTN_ADDR handling. They will never appear in VN.
SingleAccretion
force-pushed
the
Misc-VN-Cleanup
branch
from
43148e0
to
b55d061
Compare
jakobbotsch
approved these changes
Feb 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes in this set:
LCL_VAR"uses" - preserve the old behavior, reduce confusion on what should and should not be numbered, make the kinds of type mismatches we expect (and tolerate) explicit via asserts.ARGPLACEnodes - this, again, is simply wasting memory, as the nodes in question will have their VNs always reset byfgValueNumberCallanyway.Overall, we are saving a little under
0.4%in memory consumption when CG-ing x64 Release CoreLib with these changes.No diffs as expected.