improve SslStream tests on server 2022 #64968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsIt seems like server 2022 also has TLS 1.3 enabled by default and it has similar issue like Windows 11. This updates some PlatformDetection references to work as intended. cc: @safern
|
antonfirsov
reviewed
Feb 8, 2022
src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamNetworkStreamTest.cs
Outdated
Show resolved
Hide resolved
…eamNetworkStreamTest.cs Co-authored-by: Anton Firszov <[email protected]>
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephentoub
approved these changes
Feb 8, 2022
safern
approved these changes
Feb 8, 2022
|
Quic failures is #64944. rest looks like infrastructure problem. |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1816453126 |
|
@wfurt backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: improve SslStream tests on server 2022
Using index info to reconstruct a base tree...
M src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs
M src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
M src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamNetworkStreamTest.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamNetworkStreamTest.cs
Auto-merging src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
CONFLICT (content): Merge conflict in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
Auto-merging src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 improve SslStream tests on server 2022
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
This was referenced Feb 9, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like server 2022 also has TLS 1.3 enabled by default and it has similar issue like Windows 11.
This updates some PlatformDetection references to work as intended.
cc: @safern