Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Arm64 CFG dispatcher being always disabled #65095

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

AustinWise
Copy link
Contributor

Fix of a typo in #63763 . Note the that in the original, this #elif defined(TARGET_AMD64) followed a #if defined(TARGET_AMD64).

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 9, 2022
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 9, 2022
@ghost
Copy link

ghost commented Feb 9, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix of a typo in #63763 . Note the that in the original, this #elif defined(TARGET_AMD64) followed a #if defined(TARGET_AMD64).

Author: AustinWise
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@AustinWise
Copy link
Contributor Author

CC @jakobbotsch

These two constants (AMD64 and ARM64) look so similar. Is there some sort of compiler error or static analysis that can catch these sorts of mistakes?

@jakobbotsch
Copy link
Member

Thanks, indeed that's a typo. Let's see if the CI leg finds anything new.

@jakobbotsch
Copy link
Member

/azp run jit-cfg

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jakobbotsch
Copy link
Member

Looks like there are a whole slew of failures with the dispatcher enabled for ARM64. Not super critical since this is not a configuration we expect to use, but definitely something I will look into. Opened #65111 for it.

@jakobbotsch jakobbotsch merged commit 1f48351 into dotnet:main Feb 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2022
@AustinWise AustinWise deleted the austin/FixUseDispatcherTest branch January 29, 2023 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants