Allow Trace Samplers to Modify the Activity Trace State #65530
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
tarekgh
added
area-System.Diagnostics.Activity
and removed
area-System.Diagnostics.Tracing
labels
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-activity Issue DetailsFixes #63652
|
src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivitySourceTests.cs
Show resolved
Hide resolved
| { | ||
| if (setTraceWithStringParent) | ||
| { | ||
| activityOptions = activityOptions with { TraceState = traceStateValueWithStringParent }; |
There was a problem hiding this comment.
More of a design question... if I was a developer using an earlier version of the C# compiler, would I have any way to achieve the same result?
There was a problem hiding this comment.
No, to use this feature must use C# compiler version 10 or later. This is not the first feature we expose in the framework using this new syntax. System.Text.Json already using it a lot.
There was a problem hiding this comment.
I assume @reyang and @cijothomas are OK with this requirement? Effectively they will have to compile OpenTelemetry SDK with a compiler version >= 10.
There was a problem hiding this comment.
yes. OpenTelemetry SDK uses 10
src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivitySourceTests.cs
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Fixes #63652