-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Enable AddrMode for GC types on arm64 #65622
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned EgorBo
Feb 19, 2022
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 19, 2022
Tagging subscribers to this area: @JulieLeeMSFT Issue Detailsobject Test(object[] array, int i) => array[i]; ; Method Tests4:Test(System.Object[],int):System.Object:this
G_M52569_IG01:
stp fp, lr, [sp,#-16]!
mov fp, sp
G_M52569_IG02:
ldr w0, [x1,#8]
cmp w2, w0
bhs G_M52569_IG04
- ubfiz x0, x2, #3, #32
- add x0, x0, #16
- ldr x0, [x1, x0]
+ add x0, x1, #16
+ ldr x0, [x0, w2, UXTW #3]
G_M52569_IG03:
ldp fp, lr, [sp],#16
ret lr
G_M52569_IG04:
bl CORINFO_HELP_RNGCHKFAIL
brk_windows #0
-; Total bytes of code: 48
+; Total bytes of code: 44
|
/azp list |
This comment was marked as resolved.
This comment was marked as resolved.
/azp run runtime-coreclr jitstressregs, runtime-coreclr gcstress0x3-gcstress0xc, runtime-coreclr outerloop |
Azure Pipelines successfully started running 3 pipeline(s). |
…addrmode-for-gc-types
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-coreclr jitstressregs, runtime-coreclr gcstress0x3-gcstress0xc |
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #61293 (#65468 did it for floating points recently) to handle gc types too, e.g.:
Diffs: