Keep the volatility of CLS_VARs in rationalization
#65919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
dotnet-issue-labeler
bot
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsWe're expecting some negative diffs on ARM. One more step towards
|
|
@dotnet/jit-contrib |
EgorBo
reviewed
Feb 26, 2022
| if (isVolatile) | ||
| { | ||
| assignment->gtFlags |= GTF_IND_VOLATILE; | ||
| } | ||
|
|
||
| // TODO: JIT dump |
There was a problem hiding this comment.
wonder what that is supposed to mean 😄
EgorBo
reviewed
Feb 26, 2022
| @@ -453,11 +453,18 @@ void Rationalizer::RewriteAssignment(LIR::Use& use) | |||
|
|
|||
| case GT_CLS_VAR: | |||
| { | |||
| bool isVolatile = (location->gtFlags & GTF_CLS_VAR_VOLATILE) != 0; | |||
|
|
|||
| location->gtFlags &= ~GTF_CLS_VAR_VOLATILE; | |||
There was a problem hiding this comment.
is it required to reset GTF_CLS_VAR_VOLATILE ?
There was a problem hiding this comment.
Not strictly, no one will look at it once it becomes CLS_VAR_ADDR, but it's good practice to clear flags when bashing to an oper that doesn't support them.
EgorBo
approved these changes
Feb 26, 2022
AndyAyersMS
added
the
community-contribution
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some expected negative diffs on ARM.
One more step towards
CLS_VARdeletion.