Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly more aggressive ASG reversal #65920

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Feb 26, 2022

Allows us to reverse ASG(IND(const), ...), aka the static field store pattern once CLS_VAR is no more.

Diffs are mostly small CQ improvements (with a few regressions).

Allows us to reverse "ASG(IND(const), ...)".
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 26, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 26, 2022
@ghost
Copy link

ghost commented Feb 26, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Allows us to reverse ASG(IND(const), ...), aka the static field pattern once CLS_VAR is no more.

We're expecting some small CQ improvements.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@SingleAccretion SingleAccretion marked this pull request as ready for review February 26, 2022 19:32
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib - last of the changes required for CLS_VAR deletion.

@jakobbotsch jakobbotsch merged commit 136b312 into dotnet:main Mar 4, 2022
@SingleAccretion SingleAccretion deleted the More-Aggressive-Asg-Swap-Scaled-Down branch March 6, 2022 20:56
@ghost ghost locked as resolved and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants