Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use SSA def descriptors in copy propagation (#65250)" #66060

Closed
wants to merge 1 commit into from

Conversation

BruceForstall
Copy link
Member

This reverts commit 9012b23.

Fixes #65940

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 2, 2022
@ghost ghost assigned BruceForstall Mar 2, 2022
@ghost
Copy link

ghost commented Mar 2, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

This reverts commit 9012b23.

Fixes #65940

Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@BruceForstall
Copy link
Member Author

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, runtime-coreclr libraries-jitstress2-jitstressregs, runtime-coreclr jitstress2-jitstressregs, runtime-coreclr jitstress2-jitstressregs

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@BruceForstall
Copy link
Member Author

@dotnet/jit-contrib All jitstress jobs have been badly broken; hopefully this fixes it (it did for the one case I tried locally).

@kunalspathak
Copy link
Member

@SingleAccretion

Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SingleAccretion SingleAccretion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, the fix is in #66070.

@BruceForstall
Copy link
Member Author

I'm going to assume we'll merge the fix #66070 instead of this.

@BruceForstall BruceForstall deleted the Revert65250 branch March 3, 2022 07:02
@ghost ghost locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure JIT\\Performance\\CodeQuality\\Bytemark\\Bytemark\\Bytemark.cmd
3 participants