Only use first field maps for shared statics #66558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
dotnet-issue-labeler
bot
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThis change rounds out the story of redundant maps in VN by encoding the shared-ness information in the lower two bits of the handle stored inside the Addresses two Part of #58312.
|
SingleAccretion
force-pushed
the
Improve-Handling-Of-Type-Mismatch-In-VN-Part-Eleven
branch
2 times, most recently
from
d14ad65
to
3c65a34
Compare
SingleAccretion
force-pushed
the
Improve-Handling-Of-Type-Mismatch-In-VN-Part-Eleven
branch
3 times, most recently
from
2c87537
to
c5e8a2d
Compare
Allows this change to be tested via SPMI.
The field sequences are already canonical in the store, so there is no need to have the somewhat involved code in VN which essentially re-canonicalized them, we can just use the pointer value (as a handle) to encode them. Makes the future change of encoding some information in the handle a little easier.
SingleAccretion
force-pushed
the
Improve-Handling-Of-Type-Mismatch-In-VN-Part-Eleven
branch
from
c5e8a2d
to
1e24123
Compare
|
Zero diffs have been recorded: https://dev.azure.com/dnceng/public/_build/results?buildId=1667122&view=ms.vss-build-web.run-extensions-tab. |
This reverts commit b8bd75a.
|
@dotnet/jit-contrib |
jakobbotsch
reviewed
Mar 29, 2022
jakobbotsch
approved these changes
Mar 29, 2022
SingleAccretion
commented
Mar 29, 2022
SingleAccretion
deleted the
Improve-Handling-Of-Type-Mismatch-In-VN-Part-Eleven
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change rounds out the story of redundant maps for statics in VN by encoding the shared-ness information in the lower two bits of the handle stored inside the
FieldSeqNodeand using that information inIsFieldAddr.Addresses two
TODO-VNTypes. Saves~0.12%in memory consumption when R2R-ing CoreLib.No diffs are expected.
Part of #58312.