Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some small copy propagation changes #66582

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Some small copy propagation changes #66582

merged 2 commits into from
Mar 15, 2022

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Mar 14, 2022 •
edited
Loading

Address #65902 (comment).

Add some asserts now that we don't push all the defs and don't have them implicitly.

No diffs.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 14, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 14, 2022
@ghost
Copy link

ghost commented Mar 14, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

And add some asserts now that we don't push all the defs and don't have them implicitly.

No diffs are expected.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@SingleAccretion SingleAccretion changed the title Address https://github.com/dotnet/runtime/pull/65902#discussion_r818153639 Some small copy propagation changes Mar 14, 2022
@SingleAccretion SingleAccretion marked this pull request as ready for review March 14, 2022 16:53
@SingleAccretion
Copy link
Contributor Author

Will once again assume OSX timeouts are not related.

@dotnet/jit-contrib

@AndyAyersMS
Copy link
Member

@kunalspathak ptal

@kunalspathak
Copy link
Member

/azp run runtime-coreclr jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SingleAccretion
Copy link
Contributor Author

Stress failures look like #66601 and #63854.

kunalspathak
kunalspathak approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kunalspathak kunalspathak merged commit 84de128 into dotnet:main Mar 15, 2022
@SingleAccretion SingleAccretion deleted the Small-Copy-Prop-Improvements branch March 15, 2022 16:15
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@SingleAccretion @radekdoulik
Some small copy propagation changes (dotnet#66582)
5bf9b18 
* Add asserts

* Remove the quirk comment, replace with a TODO-CQ
@JulieLeeMSFT JulieLeeMSFT mentioned this pull request Apr 1, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SingleAccretion @AndyAyersMS @kunalspathak