-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore X509_V_ERR_AKID_SKID_MISMATCH #67343
Conversation
OpenSSL 3 started reporting X509_V_ERR_AKID_SKID_MISMATCH when building an X.509 chain that had mismatched AKID/SKIDs. Previously, this resulted in a PartialChain. This changes the verify callback to ignore X509_V_ERR_AKID_SKID_MISMATCH, and let PartialChain be what ends up getting reported. This is consistent with OpenSSL 1.x.
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsOpenSSL 3 started reporting X509_V_ERR_AKID_SKID_MISMATCH when building an X.509 chain that had mismatched AKID/SKIDs. Closes #67304
|
Does this affect 6.0 as well? Will we (or should we) backport the fix? |
Possibly.
As someone who has absolutely no authority on back porting, I think we should, if anything so that our |
I am running tests with the 6.0 branch too on RHEL 9 (OpenSSL 3.0). For some reason, I don't see a test failure there. The test error only appears on main. |
Hm. I wonder if this is another result of #65860. Let me see if that PR introduced this regression. |
That was a PEBKAC. I was building tests, but not running them 🤦 |
@omajid actually I think you are right, this doesn't reproduce for me on 3f26873, but does 07eab2b. I think this is a recent regression against OpenSSL 3.0. I'm going to close this for now, as this might be fixing a symptom and not a root cause. I will re-open it pending discussion on the tracking issue. |
OpenSSL 3 started reporting X509_V_ERR_AKID_SKID_MISMATCH when building an X.509 chain that had mismatched AKID/SKIDs.
Previously, this resulted in a PartialChain. This changes the verify callback to ignore X509_V_ERR_AKID_SKID_MISMATCH, and let PartialChain be what ends up getting reported. This is consistent with OpenSSL 1.x.
Closes #67304