Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the logic for regions detection #67979

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

cshung
Copy link
Member

@cshung cshung commented Apr 13, 2022

We should use the more reliable IsRegionGCEnabled call to detect if regions is enabled in the DAC.

@ghost
Copy link

ghost commented Apr 13, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

We should use the more reliable IsRegionGCEnabled call to detect if regions is enabled in the DAC.

Author: cshung
Assignees: cshung
Labels:

area-Diagnostics-coreclr

Milestone: -

@hoyosjs
Copy link
Member

hoyosjs commented Apr 13, 2022

We'll need to port this to 6.0 too

@hoyosjs
Copy link
Member

hoyosjs commented Apr 13, 2022

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/2163930799

@cshung cshung merged commit 52ae06e into dotnet:main Apr 14, 2022
@cshung cshung deleted the public/fix-regions-detection branch April 14, 2022 02:34
@ghost ghost locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants