Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various refactorings to share more code with future generators #67997

Merged
merged 19 commits into from
May 12, 2022

Commits on Apr 12, 2022

  1. Refactor PInvokeStubContext into SignatureContext and ContainingSynta…

    …xContext.
    
    Move IMarshallingGeneratorFactory creation into LibraryImportGenerator.
    Create InteropAttributeData base type for attribute info.
    Better represent how to ensure incrementality with IMarshallingGeneratorFactory instances without making them IEquatable themselves.
    jkoritzinsky committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    7287a88 View commit details
    Browse the repository at this point in the history
  2. Remove some legacy designs as we evolved away from being a simple wra…

    …pper around DllImport.
    
    Create extension methods to use in IIncrementalGenerator implementations
    jkoritzinsky committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    e7bc960 View commit details
    Browse the repository at this point in the history
  3. Unify processing for common named arguments.

    Use an extension method to report diagnostics easily.
    jkoritzinsky committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    feceaa9 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. Refactor most logic out of PInvokeStubCodeGenerator to make new gener…

    …ators that have specific requirements require less copy-paste.
    jkoritzinsky committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    96a00ad View commit details
    Browse the repository at this point in the history
  2. Fix array casting

    jkoritzinsky committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    211f1c8 View commit details
    Browse the repository at this point in the history
  3. Fix missing stage

    jkoritzinsky committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    3eef9eb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4738247 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. Update diagnostics

    jkoritzinsky committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    8d03506 View commit details
    Browse the repository at this point in the history
  2. With the new handling for diagnostic steps, the step ordering in our …

    …incremental tests changed as the tree traversal that records all of the steps was recording the cases that reported diagnostics first.
    
    Update the incremental tests to not report diagnostics to ensure that step order matches SyntaxTree order.
    jkoritzinsky committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    90e8802 View commit details
    Browse the repository at this point in the history
  3. Remove the need to pass the original syntax through the pipeline (rol…

    …l it into the context type we pass)
    jkoritzinsky committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    f2e2fe3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    db18755 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Configuration menu
    Copy the full SHA
    6fa932f View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Configuration menu
    Copy the full SHA
    6c75536 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Configuration menu
    Copy the full SHA
    2b932b2 View commit details
    Browse the repository at this point in the history
  2. PR feedback.

    jkoritzinsky committed May 10, 2022
    Configuration menu
    Copy the full SHA
    747cc2c View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Fix build

    jkoritzinsky committed May 11, 2022
    Configuration menu
    Copy the full SHA
    4c0f043 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6e1dbfb View commit details
    Browse the repository at this point in the history
  3. Fix namespaces

    jkoritzinsky committed May 11, 2022
    Configuration menu
    Copy the full SHA
    7e54c0b View commit details
    Browse the repository at this point in the history
  4. Fix build breaks.

    jkoritzinsky committed May 11, 2022
    Configuration menu
    Copy the full SHA
    82bc31d View commit details
    Browse the repository at this point in the history