Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running both normal and no_tiered_compilation scenarios for coreclr PRs #69178

Merged

Conversation

jakobbotsch
Copy link
Member

This changes innerloop/outerloop test groups to run only in the no_tiered_compilation scenario on PRs, as discussed in #69122.

@ghost
Copy link

ghost commented May 11, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This changes innerloop/outerloop test groups to run only in the no_tiered_compilation scenario on PRs, as discussed in #69122.

Author: jakobbotsch
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: -

@jakobbotsch
Copy link
Member Author

Will need to verify that it is still possible to trigger some TC testing on PRs and otherwise provide a way to do it.

@jakobbotsch
Copy link
Member Author

Success -- the automatically triggered runtime run submitted only Helix jobs in no_tiered_compilation for the runtime tests.

I've also manually triggered a runtime run from AzDO that points at refs/pull/69178/head and that properly ends up using the fuller matrix (which, among other things, still runs scenarios with both TC on and off). So testing TC changes in PRs can be done that way. Requesting other non-innerloop/outerloop pipelines that disable/enable TC should also not be affected by the change.

I opened #69192 for the installer failure and the osx-x64 test failure is known as well. PTAL @dotnet/runtime-infrastructure

cc @kouvel @jkotas @janvorli for awareness of the above.

@jakobbotsch jakobbotsch marked this pull request as ready for review May 11, 2022 17:33
@jakobbotsch
Copy link
Member Author

jakobbotsch commented May 12, 2022

Also cc @dotnet/jit-contrib for awareness of the above -- automated runtime runs on PRs will no longer run coreclr tests with TC enabled, so for PGO related changes make sure to trigger the PGO pipelines and/or the runtime job in the way I specified above.

@jakobbotsch
Copy link
Member Author

@trylek @hoyosjs @jkotas it would be nice to merge this before activity starts picking up today, can one of you approve?

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jakobbotsch jakobbotsch merged commit 7723254 into dotnet:main May 12, 2022
@jakobbotsch jakobbotsch deleted the always-disabled-TC-on-pr-validation branch May 12, 2022 12:13
@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants