Better createdump error messages #69663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon Issue DetailsRedirect stderr when launching createdump to get any error text. Added a new generate core dump ipc message that allows a error message string Fixes or improves:
|
lateralusX
reviewed
May 23, 2022
Redirect stderr when launching createdump to get any error text. Added a new generate core dump ipc message that allows a error message string to be returned for more detail on createdump errors.
lateralusX
reviewed
May 24, 2022
|
Does anybody know how to code a empty ep_char16_t string that works across all our platforms, OS's and runtimes? |
josalem
reviewed
May 24, 2022
josalem
approved these changes
May 26, 2022
ghost
locked as resolved and limited conversation to collaborators
| @@ -2399,16 +2431,36 @@ PROCCreateCrashDump(std::vector<const char*>& argv) | |||
| { | |||
| // Ignore any error because on some CentOS and OpenSUSE distros, it isn't | |||
| // supported but createdump works just fine. | |||
| ERROR("PROCCreateCrashDump: prctl() FAILED %d (%s)\n", errno, strerror(errno)); | |||
| ERROR("PROCCreateCrashDump: prctl() FAILED %s (%d)\n", errno, strerror(errno)); | |||
There was a problem hiding this comment.
Did you forget to swap errno and strerror(errno)?
There was a problem hiding this comment.
Oops, looks like I did. I'll fix it in a future PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirect stderr when launching createdump to get any error text.
Added a new generate core dump ipc message that allows a error message string
to be returned for more detail on createdump errors.
Fixes or improves:
#54521
#64069
dotnet/diagnostics#3064
dotnet/diagnostics#2976