Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ILGenerator maxstack computation #70388

Merged
merged 6 commits into from
Jun 22, 2022
Merged

Fix ILGenerator maxstack computation #70388

merged 6 commits into from
Jun 22, 2022

Commits on Jun 7, 2022

  1. Fix ILGenerator maxstack computation

    When generating a dynamic method both with many unconditional jumps, the
    ILGenerator's computation of maxstack is way to large - it adds the max
    stack of each basic block ending with an unconditional transfer
    (br, ret, throw, etc). If the generated code has many such bbs
    (eg, from the "then" clauses of if-then-else constructs) this sum can
    overflow 2^16. When it does, the maxstack recorded/used is the computed
    value mod 2^16. When that is less than the correct value, the
    JIT throws an InvalidProgramException.
    
    Keep track of the stack depth at various positions and use it to
    calculate an adjustment to the depth.
    
    Fix dotnet#63805
    panguye committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    c0ba1b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Configuration menu
    Copy the full SHA
    aa31c31 View commit details
    Browse the repository at this point in the history
  2. Suppress Emit5 tests in mono

    panguye committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    8c22d32 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Configuration menu
    Copy the full SHA
    5ee8789 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Configuration menu
    Copy the full SHA
    8d55541 View commit details
    Browse the repository at this point in the history
  2. retrigger checks

    panguye committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    89cd1fa View commit details
    Browse the repository at this point in the history