-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "? true : false" removal in ArraySortHelper.cs #70631
Conversation
Tagging subscribers to this area: @dotnet/area-system-collections |
Is there an issue tracking this JIT limitation? |
It was #4207, we should keep it open. It has good discussion / context. |
Essentialy, the issue is the same as in here #65327 - JIT doesn't do a good job "unraveling" branches. |
Why are we reverting just this one instance of the change? We have verification all the others didn't regress (beyond lack of perf test regressions)? |
Ok, so we reverted all CompareTo ones and believe that there were no other diffs in the original change. |
There are more 😞 I am investigating root causes of them just to have better understanding what exactly we're missing in jit - might do a full revert |
Reverts a change from #63095
Fixes #70373 perf regression
Unfortunately, the proper fix in the JIT is quite difficult at this point
Verified locally, cc @stephentoub