Fix perf regression in Type.op_Equality #70678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Ah, it's actually recursive, I didn't realize when I was simulating these changes 😄 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59704 regression.
There were two problems in there:
typeof(RuntimeType)wasn't CSE'd - it's handled with JIT: Enable CSE for CLS/STR const handles #70580isinstproduces complicated branch layout we're not there to fix in JIT yet (e.g. JIT: optRedundantBranches misses an opportunity #70480 and a few more existing issues).Unfortunately 1) CSE won't work without this PR's change (because of blocks' weights impacting CSE decisions)
codegen diff: https://www.diffchecker.com/rVgqsQnY